Skip to content

Add htmllive to make.bat #1373

Merged
ezio-melotti merged 4 commits intopython:mainfrom
lorenzo-delsignore:add-htmllive-windows
Sep 2, 2024
Merged

Add htmllive to make.bat #1373
ezio-melotti merged 4 commits intopython:mainfrom
lorenzo-delsignore:add-htmllive-windows

Conversation

@lorenzo-delsignore
Copy link
Contributor

@lorenzo-delsignore lorenzo-delsignore commented Aug 14, 2024

This pull request fixes #1366 issue by adding the htmllive command to the make.bat script.


📚 Documentation preview 📚: https://cpython-devguide--1373.org.readthedocs.build/

@ghost
Copy link

ghost commented Aug 14, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

@ezio-melotti ezio-melotti self-assigned this Aug 14, 2024
Copy link
Member

@ezio-melotti ezio-melotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can someone on Windows verify that it works as expected?

@ezio-melotti ezio-melotti added the type-feature Additions; New content or section needed label Aug 14, 2024
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@lorenzo-delsignore
Copy link
Contributor Author

lorenzo-delsignore commented Aug 14, 2024

I think that renaming the variables of SPHINXBUILD and SPHINXAUTOBUILD with something more readable will need a change of the Makefile of Linux too to be consistent. The problem is that the Makefile use only SPHINXBUILD variable, instead with Windows I only found this solution. In my opinion is better to mantain these two variables in the make.bat file.

@hugovk
Copy link
Member

hugovk commented Aug 14, 2024

Sure, we can keep the ALLONEWORD ones in this PR. Thanks!

@AA-Turner
Copy link
Member

Resolved merge conflicts, given I created them.

A

@ezio-melotti ezio-melotti merged commit b603868 into python:main Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-feature Additions; New content or section needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add htmllive target to make.bat

4 participants